Skip to content

gdm: init at 1.4#21870

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:gdm
Jan 14, 2017
Merged

gdm: init at 1.4#21870
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:gdm

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 14, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Jan 14, 2017

Does somebody else also gets a "Bad commit or revision" error, when building this package like travis does?

@vcunat
Copy link
Member

vcunat commented Jan 14, 2017

Nitpick: I wonder if gdm might be too ambiguous name; in particular, around Linux packaging this name tends to be mostly associated with gnome display manager – and we use the name as well:

nix-repl> gnome3.gdm.name
"gdm-3.22.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried "refs/tags/${version}", also is there a reason not to use fetchFromGitHub here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason for not using fetchFromGitHub could be how go2nix generated it :-/ I need to implement it there to make maintainers life easier.

Copy link
Member Author

@Mic92 Mic92 Jan 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, usually I replace fetchgit manually. However in this case I forgot it. @kamilchm if you take a look at how nix-prefetch-zip is implemented, it should be also possible to generate fetchFromGitHub for dependencies (the hash is calculated using the content of the directory, which should be the same as fresh checkout of the local repo). This should you also give a nice speed-up because fetchgit is kind of slow for both downloading and disk i/o.

Copy link
Member

@kamilchm kamilchm Jan 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to do it not only for the main source, but for all goDeps #19311
I need to get back to it in near future.

@LnL7 LnL7 added the 8.has: package (new) This PR adds a new package label Jan 14, 2017
@Mic92 Mic92 force-pushed the gdm branch 2 times, most recently from 909329b to ffe2736 Compare January 14, 2017 12:12
@Mic92
Copy link
Member Author

Mic92 commented Jan 14, 2017

@vcunat I also thought about this one, but did not find a better naming. Are people aware that they have to use modules to install gdm or would it lead to confusion, when they try to add gdm to systemPackages

@globin
Copy link
Member

globin commented Jan 14, 2017

How about using go-dependency-manager?

@Mic92 Mic92 merged commit 70591f8 into NixOS:master Jan 14, 2017
@Mic92 Mic92 deleted the gdm branch January 14, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants