Skip to content

r-modules: fix eval#218070

Merged
K900 merged 1 commit intoNixOS:masterfrom
K900:fix-r-eval
Feb 24, 2023
Merged

r-modules: fix eval#218070
K900 merged 1 commit intoNixOS:masterfrom
K900:fix-r-eval

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Feb 24, 2023

Not sure how this worked before. Now it at least evals.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Not sure how this worked before. Now it at least evals.
@K900 K900 requested a review from jbedo as a code owner February 24, 2023 19:45
@K900 K900 added the 1.severity: channel blocker Blocks a channel label Feb 24, 2023
@cole-h
Copy link
Member

cole-h commented Feb 24, 2023

Broken in #217870 (specifically, 5110d8b most likely).

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 24, 2023
@K900 K900 merged commit 5798b8c into NixOS:master Feb 24, 2023
@winterqt
Copy link
Member

Broken in #217870 (specifically, 5110d8b most likely).

I wonder how OfBorg's eval checks even passed for this -- unless this set isn't included for whatever reason?

@K900 K900 deleted the fix-r-eval branch July 27, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants