Unbreak snappy and tensorflow Haskell packages#217812
Merged
maralorn merged 2 commits intoNixOS:haskell-updatesfrom Feb 23, 2023
Merged
Unbreak snappy and tensorflow Haskell packages#217812maralorn merged 2 commits intoNixOS:haskell-updatesfrom
maralorn merged 2 commits intoNixOS:haskell-updatesfrom
Conversation
This just applies in the patches from a long-standing unmerged pull request. This transitively also unbreaks snappy-framing and snappy-lazy.
This just moves the package to the current head in the official repo, which has since seen patches that unbreak the ghc-9 build and work with our version of TensorFlow.
mikesperber
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
10 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
Thx, for fixing this outdated package! PR looks good and compiles. For future reference: Feel free to run |
Contributor
Author
|
@maralorn Thanks! (And will do next time.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This unbreaks the Haskell TensorFlow bindings, and - as it's a dependency - the snappy package.
This obsoletes #119411.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)