Revert "haskellPackages.heystone: fix darwin dylibs"#217683
Merged
sternenseemann merged 1 commit intohaskell-updatesfrom Feb 23, 2023
Merged
Revert "haskellPackages.heystone: fix darwin dylibs"#217683sternenseemann merged 1 commit intohaskell-updatesfrom
sternenseemann merged 1 commit intohaskell-updatesfrom
Conversation
This reverts commit 32eecc6. Reason for revert: This fix doesn't alleviate the problem in two ways: 1. It is in the aarch64-darwin section of configuration-darwin.nix, the problem appears on x86_64-darwin (bytepatch doesn't support aarch64). 2. When moving the override into the general *-darwin section, the problem with bytepatch is also unaffected, see my attempt in #217201.
sternenseemann
requested review from
cdepillabout and
maralorn
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
6.topic: darwin
Member
|
@sternenseemann Sorry about that. Thanks for putting together this revert. |
cdepillabout
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 32eecc6.
Reason for revert: This fix doesn't alleviate the problem in two ways:
It is in the aarch64-darwin section of configuration-darwin.nix, the problem appears on x86_64-darwin (bytepatch doesn't support aarch64).
When moving the override into the general *-darwin section, the problem with bytepatch is also unaffected, see my attempt in keystone: make sure dylib's install name is correct on darwin #217201.
cc @raehik
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)