xgboost: CMakeLists.txt does not respect CUDA_HOST_COMPILER#217333
Merged
samuela merged 1 commit intoNixOS:masterfrom Feb 22, 2023
Merged
xgboost: CMakeLists.txt does not respect CUDA_HOST_COMPILER#217333samuela merged 1 commit intoNixOS:masterfrom
samuela merged 1 commit intoNixOS:masterfrom
Conversation
14 tasks
Contributor
Author
|
Result of 1 package built:
|
ofborg
bot
added
10.rebuild-darwin: 1-10
nviets
approved these changes
Feb 20, 2023
Contributor
nviets
left a comment
nviets
left a comment
There was a problem hiding this comment.
Thanks - looks good to me
12 tasks
samuela
reviewed
Feb 21, 2023
Member
|
Result of 1 package built:
|
ConnorBaker
force-pushed
the
fix/xgboost-cmake-cuda-compiler
branch
from
2524283 to
85323f3
Compare
Contributor
Author
|
Fixed the issue with formatting around the |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
XGBoost's CMakeLists.txt does not respect
CUDA_HOST_COMPILER, instead using whatever the CXX compiler is. This change ensures the C/CXX compilers are provided by cudatoolkit when CUDA support is enabled.https://github.com/dmlc/xgboost/blob/ccf43d4ba0a94e2f0a3cc5a526197539ae46f410/CMakeLists.txt#L145
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)CC @abbradar @nviets