Skip to content

maintainers/scripts/haskell/hydra-report: Add comments with error causes to broken list#217242

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn:broken-reasons
Feb 28, 2023
Merged

maintainers/scripts/haskell/hydra-report: Add comments with error causes to broken list#217242
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn:broken-reasons

Conversation

@maralorn
Copy link
Member

Description of changes

An example of a list of broken packages for broken.yaml generated by the script after this change looks like this:

❯ maintainers/scripts/haskell/hydra-report.hs mark-broken-list
  - type-natural # failure building library in job https://hydra.nixos.org/build/209356952 at 2023-02-19
  - haskell-language-server # dependency missing in job https://hydra.nixos.org/build/209951330 at 2023-02-19
  - json-rpc # test failure in job https://hydra.nixos.org/build/209953544 at 2023-02-19
  - ltext # test failure in job https://hydra.nixos.org/build/209953415 at 2023-02-19
  - exon # dependency missing in job https://hydra.nixos.org/build/209954193 at 2023-02-19
  - quickcheck-lockstep # dependency missing in job https://hydra.nixos.org/build/209953465 at 2023-02-19

I don’t know how long you people will be putting up with my feature creep to this script …

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 19, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 19, 2023
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and this seems reasonable.

The only concern I'd have is that the reason something is broken may change over time. It is possible that having a link to broken build reports could be more confusing for users than helpful. Although that is just speculation, and I think it is worthwhile to try out the change in this PR and see if we like it.

@maralorn maralorn merged commit 994e845 into NixOS:haskell-updates Feb 28, 2023
@maralorn maralorn deleted the broken-reasons branch February 28, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments