maintainers/scripts/haskell/hydra-report: Add comments with error causes to broken list#217242
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Feb 28, 2023
Merged
Conversation
…ses to broken list
9a58213 to
0debf14
Compare
cdepillabout
approved these changes
Feb 28, 2023
Member
cdepillabout
left a comment
There was a problem hiding this comment.
Code looks good, and this seems reasonable.
The only concern I'd have is that the reason something is broken may change over time. It is possible that having a link to broken build reports could be more confusing for users than helpful. Although that is just speculation, and I think it is worthwhile to try out the change in this PR and see if we like it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
An example of a list of broken packages for broken.yaml generated by the script after this change looks like this:
I don’t know how long you people will be putting up with my feature creep to this script …
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)