Merged
Conversation
tranquillity-codes
force-pushed
the
master
branch
from
12b1806 to
1ed537a
Compare
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
deployed to x86_64 and aarch64, did not test all features, but default do note that upstream builds with not sure if this discrepancy is new with 1.13.1 -> 1.18.0, but it may be wise to upgrade that dependency to lua5_4 here as well. |
Author
|
Built and tested with Lua 5.4 |
uninsane
requested changes
May 29, 2023
Comment on lines
79
to
83
| # For some reason -Werror is on by default, causing the project to fail compilation. | ||
| buildPhase = '' | ||
| make | ||
| ''; | ||
| NIX_CFLAGS_COMPILE = "-Wno-error"; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
uninsane
approved these changes
May 30, 2023
uninsane
added
the
12.approvals: 1
Contributor
|
Result of 1 package built:
|
Contributor
|
@dguibert you OK merging this? |
Member
|
Ok to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/brndnmtthws/conky/releases
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)