Skip to content

haskell.packages.ghc884.ghc-lib: downgrade to match ghc-lib-parser#216475

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:ghc88-downgrade-ghc-lib
Feb 15, 2023
Merged

haskell.packages.ghc884.ghc-lib: downgrade to match ghc-lib-parser#216475
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
sternenseemann:ghc88-downgrade-ghc-lib

Conversation

@sternenseemann
Copy link
Member

Description of changes

cc @maralorn

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Feb 15, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 15, 2023
@maralorn
Copy link
Member

Does doDistribute have any effect in the non-default package set?

I didn’t override ghc-lib because everything I built worked without, and I wanted to keep overrides as small as possible. Did that have any negative effect?

@sternenseemann
Copy link
Member Author

Does doDistribute have any effect in the non-default package set?

Yes, if hydra jobs are created manually (which is the case for ghc-lib), then it matters.

Did that have any negative effect?

ghc-lib doesn't compile at the moment due to a mismatch with ghc-lib-parser.

@maralorn
Copy link
Member

Well, then. Sure, let’s fix it. Thank you for your tireless work!

@maralorn maralorn merged commit 066aaaf into NixOS:haskell-updates Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments