Skip to content

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Feb 13, 2023

Description of changes

Depends on #216235

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Feb 13, 2023
@ofborg ofborg bot requested a review from nlewo February 13, 2023 09:54
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 13, 2023
@fabaff
Copy link
Member Author

fabaff commented Feb 13, 2023

Result of nixpkgs-review pr 216139 run on x86_64-linux 1

2 packages failed to build:
  • devpi-client
  • python311Packages.check-manifest
1 package built:
  • python310Packages.check-manifest

@nlewo
Copy link
Member

nlewo commented Feb 13, 2023

@fabaff did you try to make it working with python 3.11 as well?

Also, did it work before your change?

@fabaff
Copy link
Member Author

fabaff commented Feb 13, 2023

@fabaff did you try to make it working with python 3.11 as well?

Some builds are failing because gpgme is failing on Python 3.11. Python 3.11 is not supported yet.

Also, did it work before your change?

No, https://hydra.nixos.org/build/208750916

@fabaff fabaff merged commit 2f3ed68 into NixOS:master Feb 18, 2023
@fabaff fabaff deleted the check-manifest-bump branch February 18, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants