Skip to content

nccl: 2.12.10-1 -> 2.16.5-1#215549

Merged
samuela merged 1 commit intoNixOS:masterfrom
ConnorBaker:nccl-2.16.5-1
Feb 21, 2023
Merged

nccl: 2.12.10-1 -> 2.16.5-1#215549
samuela merged 1 commit intoNixOS:masterfrom
ConnorBaker:nccl-2.16.5-1

Conversation

@ConnorBaker
Copy link
Contributor

@ConnorBaker ConnorBaker commented Feb 9, 2023 •
edited
Loading

Description of changes

Version bump.

Passthru cudaPackages instead of cudatoolkit. No users in Nixpkgs currently so nothing breaks.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.
Failures
Future work
  • Refactor to use cudaPackages instead of cudatoolkit and set NVCC_GENCODE using cudaFlags.
  • Refactor to use autoAddOpenGLRunpathHook
  • Refactor to remove dependency on cudatoolkit

cc @NixOS/cuda-maintainers

@ConnorBaker ConnorBaker mentioned this pull request Feb 9, 2023
Closed
13 tasks
@ofborg ofborg bot requested a review from mdaiter February 9, 2023 18:48
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 9, 2023
@ConnorBaker ConnorBaker force-pushed the nccl-2.16.5-1 branch 2 times, most recently from aedccec to eca4fd5 Compare February 21, 2023 01:32
@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented Feb 21, 2023

Result of nixpkgs-review pr 215549 run on x86_64-linux 1

1 package failed to build:
  • python310Packages.tensorflowWithCuda
6 packages built:
  • cudaPackages.nccl
  • python310Packages.cupy
  • python310Packages.jaxlibWithCuda
  • python310Packages.torchWithCuda
  • python311Packages.cupy
  • python311Packages.jaxlibWithCuda

@ConnorBaker
Copy link
Contributor Author

ConnorBaker commented Feb 21, 2023

cc @samuela @orivej would be able to look this over?

samuela
samuela reviewed Feb 21, 2023
View reviewed changes
Copy link
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @ConnorBaker ! just one small nit

@ConnorBaker ConnorBaker requested review from samuela and removed request for mdaiter February 21, 2023 19:28
@ofborg ofborg bot requested a review from mdaiter February 21, 2023 19:41
@samuela samuela merged commit c945931 into NixOS:master Feb 21, 2023
@ConnorBaker ConnorBaker deleted the nccl-2.16.5-1 branch February 22, 2023 01:15
@nixos-discourse
Copy link

nixos-discourse commented Mar 16, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-45/26397/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuela samuela Awaiting requested review from samuela

@mdaiter mdaiter Awaiting requested review from mdaiter

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ConnorBaker @nixos-discourse @samuela