make-initrd-ng: support wrapped executables

[lilyinstarlight]

Description of changes

This makes it so that make-initrd-ng automatically copies the unwrapped files when it encounters wrapped files, preventing the need to predict and add each wrapped file to the systemd-initrd store paths manually

The issue was noticed when gzip became wrapped and vconsole setup in systemd-initrd stopped working because only the wrapped was copied and not the unwrapped executable, so I added a test that vconsole setup works correctly in systemd-initrd (though technically gzip won't necessarily always be wrapped so this test only indirectly tests the change right now)

cc: @ElvishJerricco (since we talked about this in #stage1-systemd:nixos.org)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[ElvishJerricco]

It's definitely weird that we had the unwrapped one here and the wrapped one in luksroot.nix. But maybe we should leave the wrapped one in luksroot.nix and simply remove the line from this file? I'm pretty sure we don't want this in initrd unless LUKS is actually being used.

[lilyinstarlight]

It looks like there is a reference to the exe that could get dynamically added from systemd-gpt-auto-generator, but that's because the discoverable partitions spec does allow discovery of LUKS partitions and it's probably not important to have work if LUKS devices aren't defined in the config (someone can just boot.initrd.luks.forceLuksSupportInInitrd anyway to get it even if the device itself isn't in the config)

I'll push an update in a second

[lilyinstarlight]

I've no clue why it was added to begin with though so 🤷🏻‍♀️

[lilyinstarlight]

It looks like it came from #189676. I assume because they ran into the wrapped issue but they added it to the systemd-initrd module instead of the LUKS one for some reason

@zhaofengli Was there a reason for adding the wrapped executable here or can it be removed now that make-initrd-ng supports wrapped files with this PR?

[lilyinstarlight]

@ofborg eval
@ofborg build nixosTests.systemd-initrd-vconsole

[ElvishJerricco]

I think the last thing this PR needs is a change to the README in pkgs/build-support/kernel/make-initrd-ng/README.md. That file outlines what the program does in detail, so it needs to be updated with information about this new behavior.

[lilyinstarlight]

@ofborg build nixosTests.systemd-initrd-vconsole

I added one line to the file to document this new behavior. It's pretty short but so is the change itself, so let me know if this is still insufficient