Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpExtensions.opcache: fix test environment for darwin #215004

Merged

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Feb 6, 2023

Description of changes

The opcache extension has some tests starting a local server which is blocked by default on darwin systems.
The __darwinAllowLocalNetworking is set for the opcache extension but it gets dropped.

I'm not sure if this is the right way to handle that but it looks like it is good enough to fix the test failures we were seeing. If someone knows if there is a better way to handle this and have the ability to test it, please advise.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 215004 run on x86_64-linux 1

1 package blacklisted:
  • tests.php.withExtensions-enables-previously-disabled-extensions
76 packages built:
  • adminer
  • php (apacheHttpdPackages.php ,php81)
  • arcanist
  • bookstack
  • drush
  • easyeffects
  • freshrss
  • icingaweb2
  • libsForQt5.kcachegrind (plasma5Packages.kcachegrind)
  • lsp-plugins
  • matomo
  • matomo-beta
  • n98-magerun
  • n98-magerun2
  • nagios
  • nextcloud-news-updater
  • nominatim
  • pdepend
  • phoronix-test-suite
  • php80
  • php80Extensions.opcache
  • php80Packages.box
  • php80Packages.composer
  • php80Packages.deployer
  • php80Packages.grumphp
  • php80Packages.phan
  • php80Packages.phing
  • php80Packages.phive
  • php80Packages.php-cs-fixer
  • php80Packages.php-parallel-lint
  • php80Packages.phpcbf
  • php80Packages.phpcs
  • php80Packages.phpmd
  • php80Packages.phpstan
  • php80Packages.psalm
  • php80Packages.psysh
  • php81Extensions.opcache
  • php81Packages.box
  • php81Packages.composer
  • php81Packages.deployer
  • php81Packages.grumphp
  • php81Packages.phan
  • php81Packages.phing
  • php81Packages.phive
  • php81Packages.php-cs-fixer
  • php81Packages.php-parallel-lint
  • php81Packages.phpcbf
  • php81Packages.phpcs
  • php81Packages.phpmd
  • php81Packages.phpstan
  • php81Packages.psalm
  • php81Packages.psysh
  • php82
  • php82Extensions.opcache
  • php82Packages.box
  • php82Packages.composer
  • php82Packages.deployer
  • php82Packages.grumphp
  • php82Packages.phan
  • php82Packages.phing
  • php82Packages.phive
  • php82Packages.php-cs-fixer
  • php82Packages.php-parallel-lint
  • php82Packages.phpcbf
  • php82Packages.phpcs
  • php82Packages.phpmd
  • php82Packages.phpstan
  • php82Packages.psalm
  • php82Packages.psysh
  • platformsh
  • pulseeffects-legacy
  • qcachegrind
  • snipe-it
  • unit
  • wp-cli
  • yle-dl

@LeSuisse
Copy link
Contributor Author

LeSuisse commented Feb 6, 2023

@ofborg build phpExtensions.opcache

@LeSuisse LeSuisse marked this pull request as ready for review February 7, 2023 09:45
@LeSuisse
Copy link
Contributor Author

LeSuisse commented Feb 7, 2023

https://github.com/ofborg build php80Extensions.opcache php82Extensions.opcache

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for this :)

@mweinelt mweinelt added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Feb 8, 2023
@NickCao NickCao merged commit a1f3934 into NixOS:master Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Successfully created backport PR for release-22.11:

Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this does anything. The attribute is only removed for non-darwin platforms:

inherit __darwinAllowLocalNetworking;

Any success is likely random.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants