-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpExtensions.opcache: fix test environment for darwin #215004
phpExtensions.opcache: fix test environment for darwin #215004
Conversation
@ofborg build phpExtensions.opcache |
https://github.com/ofborg build php80Extensions.opcache php82Extensions.opcache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for this :)
Successfully created backport PR for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this does anything. The attribute is only removed for non-darwin platforms:
inherit __darwinAllowLocalNetworking; |
Any success is likely random.
Description of changes
The opcache extension has some tests starting a local server which is blocked by default on darwin systems.
The
__darwinAllowLocalNetworking
is set for the opcache extension but it gets dropped.I'm not sure if this is the right way to handle that but it looks like it is good enough to fix the test failures we were seeing. If someone knows if there is a better way to handle this and have the ability to test it, please advise.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notesResult of
nixpkgs-review pr 215004
run on x86_64-linux 11 package blacklisted:
76 packages built: