Skip to content

qt6.qtbase: fix regression#214968

Merged
wegank merged 1 commit intoNixOS:masterfrom
wegank:qt6-darwin
Feb 6, 2023
Merged

qt6.qtbase: fix regression#214968
wegank merged 1 commit intoNixOS:masterfrom
wegank:qt6-darwin

Conversation

@wegank
Copy link
Member

@wegank wegank commented Feb 6, 2023

Description of changes

#211923 crushed my PRs on master, causing PyQt6 builds to fail again on macOS...

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member Author

wegank commented Feb 6, 2023

@ofborg build python3Packages.pyqt6

@ofborg ofborg bot requested review from LunNova and NickCao February 6, 2023 17:50
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 6, 2023
@wegank
Copy link
Member Author

wegank commented Feb 6, 2023

Tested agaist python3Packages.pyqt6 and bambootracker-qt6 (in #214913) on my machine, so merging.

@wegank wegank merged commit 5e32ae2 into NixOS:master Feb 6, 2023
@wegank wegank deleted the qt6-darwin branch February 6, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant