haskellPackages.heystone: fix darwin dylibs

[cdepillabout]

Description of changes

haskellPackages.heystone is currently failing to build on x86_64-darwin on the haskell-updates branch (#213089).

@sternenseemann recommended that we add fixDarwinDylibNames, which I've done in this PR. I don't know anything about darwin though, so it is possible this is not the right fix.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[cdepillabout]

@ofborg build haskellPackages.heystone
@ofborg build haskellPackages.bytepatch

[cdepillabout]

Looks like bytepatch seemed to still fail:

https://github.com/NixOS/nixpkgs/pull/214680/checks?check_run_id=11115691727

[cdepillabout]

@ofborg build haskellPackages.heystone
@ofborg build haskellPackages.bytepatch

Trying again after adding fixDarwinDylibNames to the actual keystone package just to see if it makes a difference.

edit: I'm not sure what is going on, but it seems like that didn't work either: https://github.com/NixOS/nixpkgs/pull/214680/checks?check_run_id=11115747683.

[raehik]

edit: I'm not sure what is going on, but it seems like that didn't work either: https://github.com/NixOS/nixpkgs/pull/214680/checks?check_run_id=11115747683.

@cdepillabout is that run not aarch64-darwin? It looks like the original Hydra logs were x86_64-darwin, which pass here. That log seems to be complaining about some missing Nix attributes in aarch64-darwin (which seems quite strange, but unrelated to the dylib problem).

[cdepillabout]

is that run not aarch64-darwin? It looks like the original Hydra logs were x86_64-darwin, which pass here

Ah, I see. I think I was getting confused.

It looks like my original commit did fix this on x86_64-darwin, which is what you were originally asking about, right? I've taken just that commit and rebased it on haskell-updates in this PR as 8c3d7d94062.

This should hopefully be ready to merge in? Maybe someone from @NixOS/darwin-maintainers could take a quick look and give a thumbs up.

[cdepillabout]

Okay, it looks like this now builds on x86_64-darwin.

I'll go ahead and merge in, but feel free to leave a message if this wasn't the correct fix.

[raehik]

Perfect. Thanks for doing this (and I have a bit more context for the next time I might happen)!