Skip to content

ocamlPackages.findlib: explain how to bypass the dep conflict detection#214239

Merged
symphorien merged 1 commit into
NixOS:stagingfrom
symphorien:ocaml-conflict-verbose
Feb 18, 2023
Merged

ocamlPackages.findlib: explain how to bypass the dep conflict detection#214239
symphorien merged 1 commit into
NixOS:stagingfrom
symphorien:ocaml-conflict-verbose

Conversation

@symphorien
Copy link
Copy Markdown
Member

Inspired by #205646 (comment)

cc @vbgl

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions Bot added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Feb 2, 2023
@ofborg ofborg Bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Feb 2, 2023
@vbgl
Copy link
Copy Markdown
Contributor

vbgl commented Feb 3, 2023

Do you really want to cause such a big rebuild?

Shouldn’t this information just go into the nixpkgs manual?

@symphorien
Copy link
Copy Markdown
Member Author

It's already there, as the last paragraph of https://nixos.org/manual/nixpkgs/unstable/#sec-language-ocaml-user-guide

I thought as you were impacted and yet did not find the info, it would be good to put it in the error message.

About rebuild count, should I target staging instead?

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one person. label Feb 5, 2023
@symphorien symphorien marked this pull request as draft February 18, 2023 20:01
@symphorien symphorien changed the base branch from master to staging February 18, 2023 20:02
@symphorien symphorien marked this pull request as ready for review February 18, 2023 20:02
@symphorien symphorien merged commit 72d9c83 into NixOS:staging Feb 18, 2023
@symphorien symphorien deleted the ocaml-conflict-verbose branch February 18, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants