haskellPackages.mkDerivation: New intermediates output#213817
haskellPackages.mkDerivation: New intermediates output#213817Gabriella439 wants to merge 4 commits intoNixOS:haskell-updatesfrom
intermediates output#213817Conversation
Without that Nix change, this is hardly useful, though? |
|
Not necessarily. There are other ways to thread the full build to the incremental build, albeit with a worse UX. See, for example: https://felixspringer.xyz/homepage/blog/incrementalHaskellBuildsWithNix |
|
@Gabriella439 I think the full functionality in #212107 could be pretty neat, but I'm not sure how obvious just the functionality in this PR would be to use. Would you be willing to add a test for this functionality to |
dd3de75 to
19f4120
Compare
|
@cdepillabout I've added a test to show how to use the API. For now, how to manage the |
cdepillabout
left a comment
There was a problem hiding this comment.
LGTM. Nice test!
cc @sternenseemann about this as well, since I think he had a few concerns previously
There was a problem hiding this comment.
Would you consider adding you guys as maintainers to this test?
Or potentially adding Mercury to https://github.com/NixOS/nixpkgs/blob/b03ac42b0734da3e7be9bf8d94433a5195734b19/maintainers/team-list.nix, and then making mercury the maintainer?
There was a problem hiding this comment.
Done. Can you check that I added the maintainers correctly?
|
I'm locking and closing this pull request, because through the rebase you inadvertently requested many maintainers for review, which subscribed them to update notifications, resulting in unnecessary spam inside everyone's inbox. While we can remove their review requests, we sadly cannot unsubscribe anyone. Please create a new pull request and for the next time remember to set your PR to draft status before rebasing. In draft status, you can preview the list of maintainers that are about to be requested for review, which allows you to sidestep this issue. |
This adds a new `intermediates` output that can be used to accelerate a Haskell build by importing build products exported from a prior similar build. The motivation for this is explained by the following post: https://www.haskellforall.com/2022/12/nixpkgs-support-for-incremental-haskell.html
af5d0e1 to
2aca809
Compare
This adds a new
intermediatesoutput that can be used to accelerate a Haskell build by importing build products exported from a prior similar build.The motivation for this is explained by the following post:
https://www.haskellforall.com/2022/12/nixpkgs-support-for-incremental-haskell.html
This is a subset of the changes from #204020 that I believe are safe to merge while waiting for NixOS/nix#7362 to be reviewed. I've incorporated outstanding feedback from the last PR into this one.
I structured this to be a hash-preserving changes for Haskell packages that don't use the feature, so this won't trigger unnecessary rebuilds or breakage.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes