Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python311Packages.eth-hash: fix build #213680

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Conversation

wegank
Copy link
Member

@wegank wegank commented Jan 31, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@msm-code
Copy link
Contributor

Result of nixpkgs-review pr 213680 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • paperless
  • paperless-ng
15 packages failed to build:
  • python310Packages.cairo-lang
  • python310Packages.eth-account
  • python310Packages.eth-keyfile
  • python310Packages.eth-keys
  • python310Packages.web3
  • python311Packages.buildbot
  • python311Packages.buildbot-full
  • python311Packages.buildbot-ui
  • python311Packages.cairo-lang
  • python311Packages.eth-account
  • python311Packages.eth-keyfile
  • python311Packages.eth-keys
  • python311Packages.magic-wormhole
  • python311Packages.magic-wormhole-mailbox-server
  • python311Packages.web3
39 packages built:
  • baserow
  • buildbot (python310Packages.buildbot)
  • buildbot-full (python310Packages.buildbot-full)
  • buildbot-ui (python310Packages.buildbot-ui)
  • buildbot-worker (python310Packages.buildbot-worker)
  • gnome-keysign
  • magic-wormhole (python310Packages.magic-wormhole)
  • paperless-ngx
  • python310Packages.autobahn
  • python310Packages.channels
  • python310Packages.channels-redis
  • python310Packages.daphne
  • python310Packages.eth-abi
  • python310Packages.eth-hash
  • python310Packages.eth-rlp
  • python310Packages.eth-utils
  • python310Packages.hexbytes
  • python310Packages.labgrid
  • python310Packages.magic-wormhole-mailbox-server
  • python310Packages.magic-wormhole-transit-relay
  • python310Packages.py-ecc
  • python310Packages.py-eth-sig-utils
  • python310Packages.rlp
  • python311Packages.autobahn
  • python311Packages.buildbot-worker
  • python311Packages.channels
  • python311Packages.channels-redis
  • python311Packages.daphne
  • python311Packages.eth-abi
  • python311Packages.eth-hash
  • python311Packages.eth-rlp
  • python311Packages.eth-utils
  • python311Packages.hexbytes
  • python311Packages.labgrid
  • python311Packages.magic-wormhole-transit-relay
  • python311Packages.py-ecc
  • python311Packages.py-eth-sig-utils
  • python311Packages.rlp
  • tahoe-lafs

@msm-code
Copy link
Contributor

msm-code commented Jan 31, 2023

Didn't check all build faiulres. One that is particularly obvious:

[2/15/52 built (4 failed), 852 copied (4484.0/4487.2 MiB), 1042.9 MiB DL] building python3.11-py-ecc-6.0.0 (pytestCheckPhase): tests/test_bn128_and_bls12_381.py::test_pairing_is_non_degenerate[py_ecc.optimized_bn1
error: builder for '/nix/store/5f62bviv86jnvpph2535i1nx3p9lajlz-python3.11-magic-wormhole-mailbox-server-0.4.1.drv' failed with exit code 1;
       last 10 log lines:
       > building
       > Executing setuptoolsBuildPhase
       > Traceback (most recent call last):
       >   File "/build/magic-wormhole-mailbox-server-0.4.1/nix_run_setup", line 8, in <module>
       >     exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
       >   File "setup.py", line 20, in <module>
       >     long_description=open('README.md', 'rU').read(),
       >                      ^^^^^^^^^^^^^^^^^^^^^^^
       > ValueError: invalid mode: 'rU'
       > /nix/store/chilfhdcsnmwjl7igrw26j1lrc0zar35-stdenv-linux/setup: line 1570: pop_var_context: head of shell_variables not a function context
       For full logs, run 'nix log /nix/store/5f62bviv86jnvpph2535i1nx3p9lajlz-python3.11-magic-wormhole-mailbox-server-0.4.1.drv'.

mode U is invalid in python 11. Was removed in this commit: https://github.com/magic-wormhole/magic-wormhole-mailbox-server/blob/master/setup.py.

I don't think there is a release with this fix.

Another one is pyramid:

error: builder for '/nix/store/fi6vwr8ibyqlk7zd3917skdyy8sjj61l-python3.11-pyramid-2.0.drv' failed with exit code 1;
       last 10 log lines:
       >     return self._domains.get(domain, self).lngettext(singular, plural, num)
       >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
       > AttributeError: 'Translations' object has no attribute 'lngettext'
       >
       > ----------------------------------------------------------------------
       > Ran 2633 tests in 6.423s
       >
       > FAILED (errors=2)
       > Test failed: <unittest.runner.TextTestResult run=2633 errors=2 failures=0>
       > error: Test failed: <unittest.runner.TextTestResult run=2633 errors=2 failures=0>

related issue:

Pylons/pyramid#3678

@wegank
Copy link
Member Author

wegank commented Jan 31, 2023

Thanks, I'll take a look at them after this PR.

@@ -31,7 +32,7 @@ buildPythonPackage rec {

passthru.optional-dependencies = {
pycryptodome = [ pycryptodome ];
pysha3 = [ pysha3 ];
pysha3 = if pythonOlder "3.9" then [ pysha3 ] else [ safe-pysha3 ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only really support python 3.10 and 3.11 right now, so we could also drop pysha3 in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants