-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python311Packages.eth-hash: fix build #213680
Conversation
Result of 2 packages marked as broken and skipped:
15 packages failed to build:
39 packages built:
|
Didn't check all build faiulres. One that is particularly obvious:
mode I don't think there is a release with this fix. Another one is pyramid:
related issue: |
Thanks, I'll take a look at them after this PR. |
@@ -31,7 +32,7 @@ buildPythonPackage rec { | |||
|
|||
passthru.optional-dependencies = { | |||
pycryptodome = [ pycryptodome ]; | |||
pysha3 = [ pysha3 ]; | |||
pysha3 = if pythonOlder "3.9" then [ pysha3 ] else [ safe-pysha3 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only really support python 3.10 and 3.11 right now, so we could also drop pysha3 in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes