haskellPackages: ignore maintainers without email#213473
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Jan 30, 2023
Merged
haskellPackages: ignore maintainers without email#213473cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
The Haskell Hydra report generator (`maintainers/scripts/haskell/hydra-report.hs`) uses this `maintainer-handles.nix` script for generating a mapping of email addresses to GitHub handles. This `maintainer-handles.nix` script is necessary because the Haskell Hydra report generator gets Hydra job status info as input, but needs to ping users on GitHub. Hydra job status info only contains user emails (not GitHub handles). So the `maintainer-handles.nix` script is necessary for looking up GitHub handles from email addresses. This commit fixes the `maintainers-handles.nix` code to ignore maintainers that don't have email addresses. The code was originally assuming that all maintainers have email addresses, but there was recently a maintainer added without an email address.
Member
Author
|
Allowing maintainers to not have an email address was added in #209165. |
Member
Would be nice to fix that in Hydra. Or just cut out the middle man and construct the mapping "job name → GitHub handle" from nixpkgs directly? |
ncfavier
approved these changes
Jan 30, 2023
Member
Author
Yeah, that sounds like it might be the ideal thing to do, although I'm not sure how much work it would be. I think just ignoring maintainers without an email address is the easiest immediate thing we can do, but this definitely sounds like a good future improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The Hydra report generator was failing in https://github.com/cdepillabout/nix-haskell-updates-status/actions/runs/4036712903/jobs/6939513150 because there was a user recently(?) added that does not have an email address:
The Haskell Hydra report generator (
maintainers/scripts/haskell/hydra-report.hs) uses themaintainer-handles.nixscript for generating a mapping of email addresses to GitHub handles.This
maintainer-handles.nixscript is necessary because the Haskell Hydra report generator gets Hydra job status info as input, but needs to ping users on GitHub. Hydra job status info only contains user emails (not GitHub handles). So themaintainer-handles.nixscript is necessary for looking up GitHub handles from email addresses.This PR fixes the
maintainers-handles.nixcode to ignore maintainers that don't have email addresses. The code was originally assuming that all maintainers have email addresses, but there was recently a maintainer added without an email address.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes