Skip to content

Conversation

@wegank
Copy link
Member

@wegank wegank commented Jan 29, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member Author

wegank commented Jan 29, 2023

@ofborg build icu

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 29, 2023
@ghost ghost mentioned this pull request Jan 31, 2023
4 tasks
@github-actions github-actions bot added 6.topic: emacs Text editor 6.topic: stdenv Standard environment labels Jan 31, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of this commit is wrong; I don't see any of my commits in here.

@wegank
Copy link
Member Author

wegank commented Feb 1, 2023

The title of this commit is wrong; I don't see any of my commits in here.

I've squashed your commits in the commit that references your PR. I guess it's still OK since this PR is for testing.

@ghost
Copy link

ghost commented Feb 1, 2023

It's impossible for anybody else to figure out what you've done.

Changing the authorship on other peoples' commits is not OK.

@wegank
Copy link
Member Author

wegank commented Feb 1, 2023

Okay, I'll rebase.

@wegank
Copy link
Member Author

wegank commented Feb 1, 2023

@ofborg build stdenv

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't see #206907 anywhere in the commit history of this PR, as you claimed here.

As I pointed out, #206907 isn't rebased past #213185 so there is no way to make a clean comparison without mangling one PR or the other.

That's why we wait for them to once again have a common ancestor. This will have to happen in order for one of them to merge and the other to be merge-eligible.

@wegank
Copy link
Member Author

wegank commented Feb 1, 2023

#206907 has nothing to do with stdenv except for the one-line bump. Correct me if I'm wrong.

@github-actions github-actions bot removed 6.topic: emacs Text editor 6.topic: stdenv Standard environment labels Feb 2, 2023
@wegank wegank closed this Feb 13, 2023
@wegank wegank deleted the staging-empty branch February 13, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant