Skip to content

nixos/tests/networking: fix evaluation#213371

Merged
Artturin merged 1 commit intoNixOS:masterfrom
raphaelr:scripted-networking-tests
Jan 29, 2023
Merged

nixos/tests/networking: fix evaluation#213371
Artturin merged 1 commit intoNixOS:masterfrom
raphaelr:scripted-networking-tests

Conversation

@raphaelr
Copy link
Contributor

Fixes commands such as nix-build -A nixosTests.networking.scripted. Currently this fails: "error: The option `nodes' is used but not defined."

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Fixes commands such as `nix-build -A nixosTests.networking.scripted`.
Currently this fails: "error: The option `nodes' is used but not
defined."
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 29, 2023
@raphaelr
Copy link
Contributor Author

Maybe test cases that only apply to networkd should get their own attrset instead of them all being in testCases? Then we would not need this dummy test for scripted networking.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 29, 2023
@Artturin Artturin merged commit 82dab61 into NixOS:master Jan 29, 2023
@raphaelr raphaelr deleted the scripted-networking-tests branch January 29, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants