Skip to content

nixos/tests/networking.nix: hotfix evaluation#213118

Merged
Artturin merged 1 commit intoNixOS:masterfrom
vcunat:p/hotfix-networking-tests-eval
Jan 28, 2023
Merged

nixos/tests/networking.nix: hotfix evaluation#213118
Artturin merged 1 commit intoNixOS:masterfrom
vcunat:p/hotfix-networking-tests-eval

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jan 28, 2023

It broke by merge 8803f1d.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Jan 28, 2023
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jan 28, 2023
@vcunat
Copy link
Member Author

vcunat commented Jan 28, 2023

Oh, nixos.tests.networking.scripted.rename still won't evaluate, but if I look right that wouldn't be a channel blocker.

error: The option `nodes' is used but not defined.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 28, 2023
@Artturin
Copy link
Member

@Artturin Artturin merged commit 4cbf8b0 into NixOS:master Jan 28, 2023
@vcunat vcunat deleted the p/hotfix-networking-tests-eval branch January 29, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants