ipxe: fix build by fixing -idirafter ordering#213106
Merged
trofi merged 1 commit intoNixOS:staging-nextfrom Jan 28, 2023
Merged
ipxe: fix build by fixing -idirafter ordering#213106trofi merged 1 commit intoNixOS:staging-nextfrom
trofi merged 1 commit intoNixOS:staging-nextfrom
Conversation
`ipxe` build broke after NixOS#210004 where we started dropping default libc include path and switched to `-idirafter` way of specifying libc headers. Unfortunately the way it's implemented it injects `-idirafter` after user's flags, not before. That allows users to inject their paths before libc include paths, not after (as it would notmally happen). The change works it around for `ipxe` by pulling `-idirafter` libc flags before user's flags.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Result of 1 package built:
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipxebuild broke after #210004 where we started dropping default libc include path and switched to-idirafterway of specifying libc headers.Unfortunately the way it's implemented it injects
-idirafterafter user's flags, not before. That allows users to inject their paths before libc include paths, not after (as it would notmally happen).The change works it around for
ipxeby pulling-idirafterlibc flags before user's flags.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes