rmlint: fix NIX_* environment propagations to scons#213003
Merged
trofi merged 1 commit intoNixOS:staging-nextfrom Jan 27, 2023
Merged
rmlint: fix NIX_* environment propagations to scons#213003trofi merged 1 commit intoNixOS:staging-nextfrom
trofi merged 1 commit intoNixOS:staging-nextfrom
Conversation
scons build system does not work by default in nixpkgs envoironment as
it filters system environment and throws away NIX_* flags:
https://scons.org/doc/2.1.0/HTML/scons-user/x1750.html
Fix build system to always propagate os.environment. Drop the
workarounds that pass subset of the variables through.
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scons build system does not work by default in nixpkgs envoironment as it filters system environment and throws away NIX_* flags:
Fix build system to always propagate os.environment. Drop the workarounds that pass subset of the variables through.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes