Skip to content

haskellPackages.bytepatch: unmark broken#212967

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
raehik:haskell-unbreak-bytepatch
Jan 29, 2023
Merged

haskellPackages.bytepatch: unmark broken#212967
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
raehik:haskell-unbreak-bytepatch

Conversation

@raehik
Copy link
Contributor

@raehik raehik commented Jan 27, 2023

Description of changes

Fixes building one of my packages bytepatch. Minor dependency bump (metadata revision). Fixes the package as of commercialhaskell/all-cabal-hashes@211cbba .

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jan 27, 2023
@raehik
Copy link
Contributor Author

raehik commented Jan 27, 2023

Do I add the regenerated hackage-packages.nix here? I suppose the CI should fail without it. Edit: I've snuck a temporary commit bumping the Hackage set in so we can watch lights go green together. (For next time, what's the regular procedure here?)

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 27, 2023
@raehik raehik force-pushed the haskell-unbreak-bytepatch branch from 53e6e41 to 02ee27c Compare January 27, 2023 14:59
@raehik
Copy link
Contributor Author

raehik commented Jan 27, 2023

I'll simplify by removing the temporary Hackage bump commit, marking this as WIP, and being a little more patient for a Hackage bump. Then when that happens I'll rebase and mark as ready and look for the green checkmarks :)

@raehik raehik force-pushed the haskell-unbreak-bytepatch branch from 02ee27c to a88b6e9 Compare January 27, 2023 18:19
@raehik raehik marked this pull request as draft January 27, 2023 18:19
@raehik raehik force-pushed the haskell-unbreak-bytepatch branch from a88b6e9 to 4cf2e4c Compare January 28, 2023 16:43
@raehik raehik changed the base branch from master to haskell-updates January 28, 2023 16:45
@raehik raehik marked this pull request as ready for review January 28, 2023 16:45
@cdepillabout cdepillabout merged commit 9dd80f0 into NixOS:haskell-updates Jan 29, 2023
@cdepillabout
Copy link
Member

Thanks a lot, merged into #213089 and I've regenerated the hackage packages (so bytepatch will actually be marked as unbroken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments