Skip to content

stdenv setup: disallow references to the build directory #21287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joachifm wants to merge 3 commits into from
Closed

stdenv setup: disallow references to the build directory #21287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e01e5b8
stdenv setup: disallow references to the build directory
alexanderkjeldaas Apr 14, 2014
a75c2e0
stdenv: scan all outputs for references to build directory
joachifm Dec 22, 2016
8424941
stdenv doc: document noErrorBuildTop
joachifm Dec 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions doc/stdenv.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,15 @@ installcheck</command>.</para>
in the derivation to enable install checks.</para></listitem>
</varlistentry>

<varlistentry>
<term><varname>noErrorBuildTop</varname></term>
<listitem><para>Allow outputs to capture references to the build
directory. Normally, all outputs are scanned for references to
the build directory and the build aborted if any are found. Such
references are most likely accidental and may make the build
non-reproducible.</para></listitem>
</varlistentry>

<varlistentry>
<term><varname>preInstallCheck</varname></term>
<listitem><para>Hook executed at the start of the installCheck
Expand Down
10 changes: 10 additions & 0 deletions pkgs/stdenv/generic/setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -794,6 +794,16 @@ installCheckPhase() {
$makeFlags "${makeFlagsArray[@]}" \
$installCheckFlags "${installCheckFlagsArray[@]}" ${installCheckTarget:-installcheck}

if [ -z "$noErrorBuildTop" -a "$NIX_ENFORCE_PURITY" = "1" -a -n "$NIX_BUILD_TOP" ]; then
for output in $outputs; do
if grep -qr $NIX_BUILD_TOP ${!output} ; then
echo "ERROR: found reference to build path $NIX_BUILD_TOP in the following files"
grep -lr $NIX_BUILD_TOP ${!output}
exit 1
fi
done
done

runHook postInstallCheck
}

Expand Down