Skip to content

echidna: 2.0.4 -> 2.0.5#211774

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
arcz:echidna-2.0.5
Jan 22, 2023
Merged

echidna: 2.0.4 -> 2.0.5#211774
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
arcz:echidna-2.0.5

Conversation

@arcz
Copy link
Member

@arcz arcz commented Jan 20, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@arcz arcz requested a review from cdepillabout January 20, 2023 13:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 20, 2023
@cdepillabout
Copy link
Member

Could you do the following:

  1. Mark as a draft
  2. rebase on the haskell-updates branch and change the base branch here on github
  3. check that it still compiles
  4. unmark as a draft

(I think the marking as draft and unmarking is needed so that a lot of people don't get pinged in some instances)

We generally ask that all Haskell-related changes be made to the haskell-updates branch.

@arcz arcz marked this pull request as draft January 21, 2023 13:09
@arcz arcz changed the base branch from master to haskell-updates January 21, 2023 13:10
@arcz arcz marked this pull request as ready for review January 21, 2023 14:06
@arcz
Copy link
Member Author

arcz commented Jan 21, 2023

@cdepillabout done, I'll remember next time

@cdepillabout
Copy link
Member

Thanks, LGTM!

@cdepillabout cdepillabout merged commit f414808 into NixOS:haskell-updates Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments