add rustc and cargo to the cross trunk#211254
Merged
Artturin merged 1 commit intoNixOS:masterfrom Jan 31, 2023
Merged
Conversation
Compiling them can take hours, and with rust specifically it's quite common to cross compile (e.g. to musl/static for easier distribution)
yu-re-ka
approved these changes
Jan 17, 2023
Contributor
|
can't judge if this has any significant effects on hydra builds that should be considered |
Member
|
For future I think the "cross people" should consider some better approach for the built combinations than a single large matrix. For example, this PR added 2*65 jobs and I wonder how big a fraction will actually be useful. (You know, they'll all get fully rebuilt a few times each month.) |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling them can take hours, and with rust specifically it's quite common to cross compile (e.g. to musl/static for easier distribution)
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes@Mindavi I'd be happy to get a review, I'm quite unsure about how this works