Skip to content

add rustc and cargo to the cross trunk#211254

Merged
Artturin merged 1 commit intoNixOS:masterfrom
wucke13:add-cross-derivations
Jan 31, 2023
Merged

add rustc and cargo to the cross trunk#211254
Artturin merged 1 commit intoNixOS:masterfrom
wucke13:add-cross-derivations

Conversation

@wucke13
Copy link
Contributor

@wucke13 wucke13 commented Jan 17, 2023

Compiling them can take hours, and with rust specifically it's quite common to cross compile (e.g. to musl/static for easier distribution)

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Mindavi I'd be happy to get a review, I'm quite unsure about how this works

Compiling them can take hours, and with rust specifically it's quite common to
cross compile (e.g. to musl/static for easier distribution)
@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 17, 2023
@yu-re-ka
Copy link
Contributor

yu-re-ka commented Jan 18, 2023

can't judge if this has any significant effects on hydra builds that should be considered
otherwise I'm very much in favor of this since I'm regularly building cross rustcs

@SuperSandro2000 SuperSandro2000 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 23, 2023
@yu-re-ka yu-re-ka requested a review from vcunat January 24, 2023 11:55
@Artturin Artturin merged commit e15d68c into NixOS:master Jan 31, 2023
@vcunat
Copy link
Member

vcunat commented Jan 31, 2023

For future I think the "cross people" should consider some better approach for the built combinations than a single large matrix. For example, this PR added 2*65 jobs and I wonder how big a fraction will actually be useful. (You know, they'll all get fully rebuilt a few times each month.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants