Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 10, 2023

Description of changes

Several coreutils tests assume there exists a user with uid=1000. We need to disable these tests in the sandbox.

Things done

Several coreutils tests assume there exists a user with uid=1000.
We need to disable these tests in the sandbox.
@ghost ghost mentioned this pull request Jan 10, 2023
4 tasks
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Jan 10, 2023
@ofborg ofborg bot requested a review from dasJ January 10, 2023 23:27
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 10, 2023
@ghost ghost marked this pull request as ready for review January 11, 2023 00:11
@Artturin
Copy link
Member

Why hasn't this been failing before?

@ghost
Copy link
Author

ghost commented Jan 14, 2023

Why hasn't this been failing before?

I have two theories:

  1. This only happens on powerpc64le-linux, in which case it is not a nixpkgs issue
  2. Not all of my builders are running the latest nix, and some lack this commit: NixOS/nix@2fde7e0

I'm running some builds now to find out which one it is. In either case I've draftified this PR and will remove it from the inclusion-set of #209870.

Does Hydra have the uid-range feature enabled?

@ghost ghost marked this pull request as draft January 14, 2023 05:06
@ghost
Copy link
Author

ghost commented Jan 14, 2023

Ooh, yeah. From just before that commit to nix, which wasn't included until 2.12:

https://github.com/NixOS/nix/blob/40911d7dec75541a400fe8f556d4c70a7f845fac/src/libstore/build/local-derivation-goal.hh#L102

@Artturin
Copy link
Member

These haven't been failing on nix versions before 2.12 🤔

@ghost
Copy link
Author

ghost commented Jan 14, 2023

Yeah both of my build clusters (x86_64-linux and powerpc64le-linux) have made it past one build of coreutils without this, so I'll probably just close this and call it a heisenbug.

@Artturin
Copy link
Member

Btw do you have matrix? Would be cool to have you in
#stdenv:nixos.org
https://matrix.to/#/!OqhvaDMJdKYUicLDiE:nixos.org?via=matrix.org&via=nixos.dev&via=nixos.org

@ghost
Copy link
Author

ghost commented Jan 14, 2023

Btw do you have matrix?

I'm amjoseph on hackint.de (#nix-rfc-133) and libera.chat (#nixos, #nixos-dev, and #spectrum). Both are bridged with matrix and we have plenty of |m users in channels on both of them.

Did nixorg ever manage to figure out how to bridge IRC into their matrix server?

@ghost
Copy link
Author

ghost commented Jan 14, 2023

Yep, it's a heisenbug. Everything built fine without this. WTF.

PS, it sometimes takes me a while to respond to mentions on IRC. I deliberately don't have any kind of audio or desktop notification for synchronous chat. I appreciate the usefulness of IRC/tox/etc, but from a productivity/willpower standpoint I have to be really careful with it. So if you see me commenting here on github but I haven't replied to a message on IRC for multiple hours I'm not ignoring you! I just can't let myself do interrupt-driven chat, it doesn't work for me.

@ghost ghost closed this Jan 14, 2023
@ghost ghost deleted the pr/coreutils/tests-disable-uid1000 branch January 23, 2024 06:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant