simple-dlna-browser: Add new package#209769
simple-dlna-browser: Add new package#209769SuperSandro2000 merged 3 commits intomasterfrom unknown repository
Conversation
|
Hello @LoveIsGrief , sure, would it be enough to add a header at the top of the script? |
|
I've licenced the script with the https://en.wikipedia.org/wiki/Fair_License , I hope this makes clear and easy the inclusion of the file, happy new year 🍻 , https://github.com/javier-lopez/learn/blob/master/sh/tools/simple-dlna-browser#L9 |
|
Thank you @javier-lopez ! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1681 |
SuperSandro2000
left a comment
There was a problem hiding this comment.
Please follow the contributing guide when naming your commits.
|
Thanks for the review @SuperSandro2000 ! |
SuperSandro2000
left a comment
There was a problem hiding this comment.
I missed some things the first time, sorry.
A useful CLI script I found that's way light than VLC and other GUI apps since SSDP is pretty much a text-based protocol built on top of HTTP.
|
That's alright, I learned something new. Thanks again |
Description of changes
Add a useful CLI script I found that's way light than VLC and other GUI apps since SSDP is pretty much a text-based protocol built on top of HTTP. It has no license attached so I marked it as unfree.
If the author adds a license, we will be able to specify it. @javier-lopez, would you be willing to add a license to your
simple-dlna-browserscript for its inclusion in NixOS?Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes