Skip to content

Comments

simple-dlna-browser: Add new package#209769

Merged
SuperSandro2000 merged 3 commits intomasterfrom
unknown repository
Jan 23, 2023
Merged

simple-dlna-browser: Add new package#209769
SuperSandro2000 merged 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 8, 2023

Description of changes

Add a useful CLI script I found that's way light than VLC and other GUI apps since SSDP is pretty much a text-based protocol built on top of HTTP. It has no license attached so I marked it as unfree.
If the author adds a license, we will be able to specify it. @javier-lopez, would you be willing to add a license to your simple-dlna-browser script for its inclusion in NixOS?

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 8, 2023
@javier-lopez
Copy link

Hello @LoveIsGrief , sure, would it be enough to add a header at the top of the script?

@javier-lopez
Copy link

I've licenced the script with the https://en.wikipedia.org/wiki/Fair_License , I hope this makes clear and easy the inclusion of the file, happy new year 🍻 , https://github.com/javier-lopez/learn/blob/master/sh/tools/simple-dlna-browser#L9

@ghost
Copy link
Author

ghost commented Jan 9, 2023

Thank you @javier-lopez !

@ofborg ofborg bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jan 9, 2023
@ghost ghost marked this pull request as ready for review January 9, 2023 21:05
@ghost ghost requested a review from alyssais as a code owner January 9, 2023 21:05
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1681

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the contributing guide when naming your commits.

@ghost ghost requested review from SuperSandro2000 and removed request for alyssais January 12, 2023 21:16
@ghost
Copy link
Author

ghost commented Jan 12, 2023

Thanks for the review @SuperSandro2000 !

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed some things the first time, sorry.

A useful CLI script I found that's way light than VLC and other GUI apps since SSDP
 is pretty much a text-based protocol built on top of HTTP.
@ghost
Copy link
Author

ghost commented Jan 13, 2023

That's alright, I learned something new. Thanks again

@ghost ghost requested a review from SuperSandro2000 January 13, 2023 14:40
@SuperSandro2000 SuperSandro2000 merged commit 9441b22 into NixOS:master Jan 23, 2023
@ghost ghost deleted the simple-dlna-browser branch January 27, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants