nodejs: 14.21.1 -> 14.21.2, 16.18.1 -> 16.19.0, 18.12.1 -> 18.13.0, 19.2.0 -> 19.4.0

[anthonyroussel]

Description of changes

• https://nodejs.org/en/blog/release/v19.4.0/
• https://nodejs.org/en/blog/release/v19.3.0/
• https://nodejs.org/en/blog/release/v18.13.0/
• https://nodejs.org/en/blog/release/v16.19.0/
• https://nodejs.org/en/blog/release/v14.21.2/

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1686

[marsam]

Thank you! Please target it to staging-next

[anthonyroussel]

Thank you! Please target it to staging-next

@marsam Thanks for the review. I retargeted the PR to staging-next.

[anthonyroussel]

Fixed the failing build for nodejs-19_x, cause was patches in pkgs/development/web/nodejs/npm-patches.nix are now useless for nodejs-19_x because they are merged upstream.

They are still required for NodeJS 14, 16, 18 however.

[anthonyroussel]

Rebased my branch against staging-next.

[marsam]

Thank you!

[winterqt]

Hi @marsam, just checking: do you remember why you sent this directly into an active -next? It doesn't seem to be security related. Thanks!

[marsam]

Hi, I suggested to send it to staging-next because Node v19.3.0 updated npm to 9.2.0, and staging-next had npmPatches which were backports of npm 9.
If this PR landed to master first, it would break nodejs-19_x when staging-next is merged since it merges cleanly, even though npmPatches were conflicting.