assimp: 5.1.3 → 5.2.5

[fabianhjr]

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[stephank]

Result of nixpkgs-review pr 209740 run on aarch64-darwin 1

2 packages built:

• assimp
• qt6.qt3d (qt6Packages.qt3d)

While this builds, the assimp binary is no longer there. The lib output is fine, but the out output is empty. Is that expected / also the case on Linux?

[fabianhjr]

Result of nixpkgs-review pr 209740 run on aarch64-darwin 1
2 packages built:

While this builds, the assimp binary is no longer there. The lib output is fine, but the out output is empty. Is that expected / also the case on Linux?

Unsure, it was a version bump due to #206907 and only checked compilation.

Removed the flag changes, could you check if this still has the issue you noticed?

[stephank]

That didn't make a difference, but I tried a Linux build in a VM and it also no longer has the binary.

It looks like the binaries were disabled by default in this commit: assimp/assimp@eee6269

Seems from the linked issue it was a Windows-specific change. Maybe we can re-enable it in our builds?

cmakeFlags = [ "-DASSIMP_BUILD_ASSIMP_TOOLS=ON" ];

I tried Linux and Darwin builds with this flag, and both produce working binaries.

[fabianhjr]

Thanks for looking into it

/nix/store/7k7qadw5ikffxg44dh76zvhr7sv4g2ng-assimp-5.2.5
└── bin
    └── assimp