Skip to content

stdenv: add minimal flag#209601

Closed
ghost wants to merge 10 commits intostagingfrom
unknown repository
Closed

stdenv: add minimal flag#209601
ghost wants to merge 10 commits intostagingfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jan 8, 2023

Description of changes

This is #209462, plus optimizations to reduce the number of rebuilds on aarch64. The complexity/benefit tradeoff here is up for debate.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Adam Joseph added 10 commits January 7, 2023 12:17
stdenv: add rebootstrap parameter
1a0bdc0
aarch64: enable rebootstrap, upgrade to gcc11
12408bc 
Incorporates changes from:

- #209459

Should fix:

- #108111
- #108305
- #201254

Alternative to:

- #209063
stdenv: mark binutils-patchelfed
e0ccba7 
The stdenv bootstrap creates several wrappers around binutils, and
gives them the exact same drvName as the binutils package itself.

These wrappers cost almost nothing to create (they are just file
copies and patchelf runs, not builds), so we should distinguish them
from expensive binutils builds with a unique pname.  This commit
does that.
make-bootstrap-tools.nix: allow to override bootGCC and busyboxMinimal
4837fb4
stdenv/linux: avoid unnecessary rebuilds when rebootstrapping
b5c952b
gcc11: allow compilation without libxcrypt
201d526
perl: allow compilation without libxcrypt
53c7484
cpython: allow compilation without libxcrypt
31127c4
make-bootstrap-tools: take coreutilsMinimal, cpio from pkgs
8d0d8e7
stdenv: add minimal flag
77c2173
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment labels Jan 8, 2023
@ghost ghost mentioned this pull request Jan 8, 2023
Closed
2 tasks
@ofborg ofborg bot added 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: package (new) This PR adds a new package labels Jan 8, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 8, 2023
@ghost ghost closed this Jun 21, 2023
@ghost ghost deleted the pr/aarch64/gcc11-faster branch June 21, 2023 05:19
@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@vcunat vcunat Awaiting requested review from vcunat

@adevress adevress Awaiting requested review from adevress

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@Synthetica9 Synthetica9 Awaiting requested review from Synthetica9

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants