pkgsCross.ghcjs.haskellPackages.ghc: don't revert edited config.sub#209522
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Jan 7, 2023
Merged
Conversation
GHC ships a [modified] config.sub so that js-unknown-ghcjs is accepted by autotools. For some platforms, we automatically update config.sub from upstream's source in order to prevent that builds fail when we use an outdated config.sub. In this case of course the perfectly up to date config.sub would reject the target platform we are trying to use, so we must disable this mechanism for now. I have asked in the GHC IRC channel if there are any plans on upstreaming the platform. It would be nice if were able to drop this change in the future.
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHC ships a [modified] config.sub so that js-unknown-ghcjs is accepted by autotools. For some platforms, we automatically update config.sub from upstream's source in order to prevent that builds fail when we use an outdated config.sub. In this case of course the perfectly up to date config.sub would reject the target platform we are trying to use, so we must disable this mechanism for now.
I have asked in the GHC IRC channel if there are any plans on upstreaming the platform. It would be nice if were able to drop this change in the future.
Fixes the failure on aarch64-linux.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes