nixos: add service to propagate status of activationScripts#208942
nixos: add service to propagate status of activationScripts#208942bjornfor wants to merge 1 commit intoNixOS:masterfrom
Conversation
This change makes `systemctl --failed` indicate the result of the NixOS activation scripts, instead of making their failure only visible if you (1) manually look at system logs or (2) run the activation script manually. I'm re-using the existing /run/nixos directory for the (runtime) state.
1847a9a to
f61d7ea
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/1735 |
SuperSandro2000
left a comment
There was a problem hiding this comment.
this feels hacky to me. Could we make this more straight forward?
I'm open to ideas. I guess when we at some point(?) get systemd in stage-1, we'd implement activationScripts as a systemd service and this won't be needed anymore? But until then, I really think we should have a way to tell systemd about activationScripts failures, like this PR. |
|
Ping? If nobody has anything more to say, I plan to merge in one week. |
We have that though! #164943 |
Cool! I didn't know that. I'll try to test it. |
Description of changes
This change makes
systemctl --failedindicate the result of the NixOSactivation scripts, instead of making their failure only visible if you
(1) manually look at system logs or (2) run the activation script
manually.
I'm re-using the existing /run/nixos directory for the (runtime) state.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes