Python: use fixed-point combinator, add pkgs to interpreter#20893
Merged
FRidh merged 3 commits intoNixOS:masterfrom Dec 5, 2016
Merged
Python: use fixed-point combinator, add pkgs to interpreter#20893FRidh merged 3 commits intoNixOS:masterfrom
FRidh merged 3 commits intoNixOS:masterfrom
Conversation
FRidh
added
2.status: work-in-progress
6.topic: python
Member
Author
|
This is a smaller change than I proposed in #16784. All packages work just fine with this change. With this change I don't think it will be possible anymore to have overrides of |
FRidh
added
the
0.kind: enhancement
FRidh
force-pushed
the
fixed3
branch
2 times, most recently
from
13a28a1 to
1509533
Compare
Use a fixed-point combinator for the Python package set to allow easier overriding of its contents. Earlier implementations were proposed in NixOS#16784 and NixOS#17428. This commit is by comparison much smaller and changes only what is needed.
A package set is constructed for a specific interpreter. Therefore, we add the possibility to override the package set to the interpreter. This should make it easier to override the interpreter and the package set at the same time.
Member
|
You rock :) |
johbo
added a commit
to nix-community/pip2nix
that referenced
this pull request
Dec 23, 2016
Since NixOS/nixpkgs#20893 the python packages are based on a fix point combinator and they don't support the attribute override anymore. This commit adjusts the template for default.nix so that it works with the upcoming change and still supports the old variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Use a fixed-point combinator for the Python package set to allow easier overriding of its contents.
Earlier implementations were proposed in #16784 and #17428. This commit is by comparison much smaller and changes only what is needed.
A package set is constructed for a specific interpreter. Therefore, we add the
possibility to override the package set to the interpreter. This should make it
easier to override the interpreter and the package set at the same time.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)