Skip to content

i3: 4.21.1 -> 4.22, i3-gaps: drop#208861

Merged
fpletz merged 3 commits intoNixOS:masterfrom
reedrw:i3-422
Jan 3, 2023
Merged

i3: 4.21.1 -> 4.22, i3-gaps: drop#208861
fpletz merged 3 commits intoNixOS:masterfrom
reedrw:i3-422

Conversation

@reedrw
Copy link
Copy Markdown
Contributor

@reedrw reedrw commented Jan 3, 2023

Description of changes

i3 has been updated to version 4.22, this version at long last merges the i3-gaps fork, which has been maintained in parallel for years. The former maintainer of i3-gaps has asked that package maintainers replace it with i3, as it will no longer be updated. i3-gaps users can safely move to upstream i3 without any changes in behavior, so I've replaced the i3-gaps package with an alias to i3.

Full release notes: https://github.com/i3/i3/blob/4.22/RELEASE-NOTES-4.22

Things done

i3 updated to 4.22, i3-gaps removed and replaced with an alias to i3 so peoples' configs aren't broken.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Jan 3, 2023
@ofborg ofborg bot requested review from fpletz and globin January 3, 2023 10:59
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 3, 2023
@reedrw
Copy link
Copy Markdown
Contributor Author

reedrw commented Jan 3, 2023

This should also affect the module documentation and removed module assertion for the i3 module, but I'm not sure whether or not a separate PR is warranted.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 3, 2023
@reedrw reedrw changed the title I3: 4.21.1 -> 4.22, i3-gaps: drop i3: 4.21.1 -> 4.22, i3-gaps: drop Jan 3, 2023
@fpletz fpletz merged commit c8c6436 into NixOS:master Jan 3, 2023
@reedrw reedrw deleted the i3-422 branch January 3, 2023 15:30
@dasJ
Copy link
Copy Markdown
Member

dasJ commented Jan 9, 2023

i3-gaps is still used in the polybar package which is now broken if aliases are disabled

dasJ added a commit to helsinki-systems/nixpkgs that referenced this pull request Jan 10, 2023
Breaks when no aliases are enabled since NixOS#208861
@dasJ dasJ mentioned this pull request Jan 10, 2023
13 tasks
adamcstephens pushed a commit to adamcstephens/nixpkgs that referenced this pull request Jan 25, 2023
Breaks when no aliases are enabled since NixOS#208861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants