Skip to content

python3Packages.lox: init at 0.11.0#208653

Closed
jpetrucciani wants to merge 1 commit intoNixOS:masterfrom
jpetrucciani:add_lox
Closed

python3Packages.lox: init at 0.11.0#208653
jpetrucciani wants to merge 1 commit intoNixOS:masterfrom
jpetrucciani:add_lox

Conversation

@jpetrucciani
Copy link
Member

@jpetrucciani jpetrucciani commented Jan 1, 2023

Description of changes

I would like to be able to use the lox python library for nicer syntactic sugar for multi-threading+processing from within nixpkgs!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 1, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 1, 2023
@JamieMagee
Copy link
Member

JamieMagee commented Jan 8, 2023

Result of nixpkgs-review pr 208653 run on x86_64-linux 1

2 packages built:
  • python310Packages.lox
  • python39Packages.lox

JamieMagee
JamieMagee reviewed Jan 8, 2023
View reviewed changes
@jpetrucciani jpetrucciani force-pushed the add_lox branch 2 times, most recently from 3cedb6d to e706452 Compare January 8, 2023 20:14
@jpetrucciani
Copy link
Member Author

jpetrucciani commented Jan 25, 2023

This has switched checkInputs to nativeCheckInputs to satisfy the recent tree-wide change (#206742)!

@JamieMagee
Copy link
Member

JamieMagee commented Feb 14, 2023

Result of nixpkgs-review pr 208653 run on x86_64-linux 1

2 packages built:
  • python310Packages.lox
  • python311Packages.lox

@Alizter
Copy link
Contributor

Alizter commented Mar 23, 2023

Result of nixpkgs-review pr 208653 run on x86_64-linux 1

6 packages failed to build:
  • python310Packages.lox
  • python310Packages.lox.dist
  • python310Packages.lox.doc
  • python311Packages.lox
  • python311Packages.lox.dist
  • python311Packages.lox.doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@JamieMagee JamieMagee Awaiting requested review from JamieMagee

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpetrucciani @JamieMagee @Alizter