Skip to content

Comments

python3Packages.pygments: 2.13.0 -> 2.14.0#208594

Merged
mweinelt merged 6 commits intoNixOS:stagingfrom
ncfavier:pygments
Feb 27, 2023
Merged

python3Packages.pygments: 2.13.0 -> 2.14.0#208594
mweinelt merged 6 commits intoNixOS:stagingfrom
ncfavier:pygments

Conversation

@ncfavier
Copy link
Member

@ncfavier ncfavier commented Jan 1, 2023

https://github.com/pygments/pygments/releases/tag/2.14.0

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 1, 2023
@ncfavier ncfavier force-pushed the pygments branch 2 times, most recently from 4072b87 to 289d10e Compare January 5, 2023 22:18
@ncfavier
Copy link
Member Author

ncfavier commented Jan 6, 2023

Anything else I should test beyond basic functionality of pygments itself?

Ofborg seems useless here...

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 6, 2023 •
edited by ncfavier
Loading

@ofborg eval

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 6, 2023

Anything else I should test beyond basic functionality of pygments itself?

We are running tests, so should be fine.

ofborg fails because cache is missing.

@ncfavier
Copy link
Member Author

ncfavier commented Jan 6, 2023

No dice. python3Packages.pygments.tests builds fine on the PR's tip (not rebased on staging).

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 6, 2023

It doesn't build at all on rebased on staging because sphinx tests fail right now.

@ncfavier
Copy link
Member Author

ncfavier commented Jan 9, 2023

Where do we go from here? Surely I can't be expected to rebuild the world on my laptop just to update a package that runs fine on master?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 11, 2023 •
edited
Loading

We wait until that is fixed :P

@ofborg eval

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 11, 2023

I think the failure is caused by the pygments update. I couldn't produce it before.

@ncfavier
Copy link
Member Author

ncfavier commented Jan 12, 2023 •
edited
Loading

sphinx-doc/sphinx@965768b

@ncfavier ncfavier mentioned this pull request Jan 12, 2023
Merged
13 tasks
@ncfavier
Copy link
Member Author

ncfavier commented Jan 12, 2023

#210338

@ncfavier
Copy link
Member Author

ncfavier commented Jan 12, 2023

Since the sphinx update might take time, I've just disabled the failing tests.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 12, 2023
@ncfavier
Copy link
Member Author

ncfavier commented Jan 17, 2023 •
edited
Loading

Is this good enough to merge?

@ofborg eval

SuperSandro2000
SuperSandro2000 reviewed Jan 19, 2023
View reviewed changes
SuperSandro2000
SuperSandro2000 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofborg build python310Packages.pygments python310Packages.sphinx

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 28, 2023

I just pushed an update for rich to this branch because the latest update had a fix for pygments.

@ncfavier
Copy link
Member Author

ncfavier commented Jan 28, 2023 •
edited
Loading

rich 13.3.0 breaks textual's tests...

@ncfavier ncfavier mentioned this pull request Feb 2, 2023
Closed
13 tasks
@ncfavier
Copy link
Member Author

ncfavier commented Feb 4, 2023 •
edited
Loading

This is still broken: now ipython's tests are failing.

I don't know how we usually deal with this.

@mweinelt
Copy link
Member

mweinelt commented Feb 4, 2023

Step by step.

@ncfavier
Copy link
Member Author

ncfavier commented Feb 4, 2023 •
edited
Loading

Okay, #215904 should fix ipython via ipython/ipython#13882.

@mweinelt mweinelt added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 5, 2023
SuperSandro2000
SuperSandro2000 reviewed Feb 22, 2023
View reviewed changes
pkgs/development/python-modules/textual/default.nix Outdated
Copy link
Member

@SuperSandro2000 SuperSandro2000 Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add why

Copy link
Member Author

@ncfavier ncfavier Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated textual instead (which required a markdown-it-py update), now tests pass.

pkgs/development/python-modules/pandas/default.nix Outdated
Comment on lines +52 to +53
Copy link
Member

@SuperSandro2000 SuperSandro2000 Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should move this to python-packages

Copy link
Member Author

@ncfavier ncfavier Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we still want the top-level hypothesis to have documentation?

Copy link
Member

@SuperSandro2000 SuperSandro2000 Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean if we should move the overwrite to the attr set passed to pandas callPackage.

@tfc tfc mentioned this pull request Feb 22, 2023
Closed
12 tasks
ncfavier and others added 6 commits February 22, 2023 18:43
@ncfavier
python3Packages.pygments: 2.13.0 -> 2.14.0
6ae5aa0 
https://github.com/pygments/pygments/releases/tag/2.14.0
@ncfavier
sphinx: disable tests that fail with pygments 2.14
1f726ee 
sphinx-doc/sphinx@965768b
@SuperSandro2000 @ncfavier
python310Packages.rich: 13.0.0 -> 13.3.0
45d8a77 
Fixes pygments compatibility
https://github.com/Textualize/rich/blob/HEAD/CHANGELOG.md
@ncfavier
python3Packages.pandas: break dependency cycle with hypothesis docs
a5b6653 
hypothesis → sphinx-autocodelink → ipython → stack-data → executing →
rich → markdown-it-py → pytest-regressions → pandas
@ncfavier
python3Packages.markdown-it-py: 2.1.0 -> 2.2.0
b58e7b3 
https://github.com/executablebooks/markdown-it-py/releases/tag/v2.2.0
@ncfavier
python3Packages.textual: 0.10.1 -> 0.11.1
c3a9358
@ncfavier
Copy link
Member Author

ncfavier commented Feb 22, 2023

pygments, pygments.tests build fine on master with #215904 applied. Maybe it's time to merge both PRs?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Feb 23, 2023

It is probably a better idea to wait for a python-updates run to fix possible other regressions in big style.

@mweinelt mweinelt merged commit f4c041b into NixOS:staging Feb 27, 2023
@mweinelt
Copy link
Member

mweinelt commented Feb 27, 2023

Meh. wrong destination branch hit.

@ncfavier ncfavier deleted the pygments branch February 27, 2023 09:06
@ncfavier ncfavier mentioned this pull request Feb 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@dotlambda dotlambda Awaiting requested review from dotlambda

@mweinelt mweinelt Awaiting requested review from mweinelt

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@risicle risicle Awaiting requested review from risicle

@bhipple bhipple Awaiting requested review from bhipple

@joelkoen joelkoen Awaiting requested review from joelkoen

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

Python batch upgrade
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ncfavier @SuperSandro2000 @mweinelt @joelkoen