Skip to content

haskellPackages: unbreak hevm#208484

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
arcz:unbreak-hevm
Jan 1, 2023
Merged

haskellPackages: unbreak hevm#208484
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
arcz:unbreak-hevm

Conversation

@arcz
Copy link
Member

@arcz arcz commented Dec 31, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 31, 2022
@sternenseemann
Copy link
Member

sternenseemann commented Dec 31, 2022

Why are the tests disabled?

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 31, 2022
@arcz
Copy link
Member Author

arcz commented Dec 31, 2022

@sternenseemann there are a couple of very heavy test suites one requires network access and they needs external repos fetched

cdepillabout
cdepillabout reviewed Dec 31, 2022
View reviewed changes
pkgs/development/haskell-modules/configuration-nix.nix Outdated
Copy link
Member

@cdepillabout cdepillabout Dec 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave a comment about why tests are disabled?

Thanks for removing the patch!

Copy link
Member Author

@arcz arcz Dec 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package and removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 31, 2022
cdepillabout
cdepillabout approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cdepillabout cdepillabout merged commit 7584aa9 into NixOS:haskell-updates Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arcz @sternenseemann @cdepillabout