Add a patch to allow true-name to build with current template-haskell.#208428
Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom Jan 2, 2023
Merged
Conversation
nuttycom
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Moved to draft in order to pull the patch via |
nuttycom
force-pushed
the
haskell-unbreak_true_name
branch
from
4b909a4 to
6d54eb7
Compare
Contributor
Author
|
Rebased & ready for review. |
Member
|
Thanks, this looks good! One more quick thing though. Commit messages in Nixpkgs are supposed to have a specific format: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md So the commit in this PR should maybe look like: Other than that, this looks good. Sorry for the back-and-forth! |
… template-haskell. This updates the `true-name` package to include changes up to version 0.1.0.4, as well as compilation failures when building with template-haskell version 2.16 and higher.
nuttycom
force-pushed
the
haskell-unbreak_true_name
branch
from
6d54eb7 to
2d3c98f
Compare
Contributor
Author
|
force-pushed to fix the commit message, thanks! |
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This patches the Haskell
true-namepackage to build with current ghc versions available from nixpkgs.The patch includes the updates included in the 0.1.0.4 version of
true-name(which has never had a Hackage release) and also applies https://github.com/liyang/true-name/pull/4.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes