git: set reasonable default features#207831
Conversation
mweinelt
left a comment
There was a problem hiding this comment.
Allowing the send-email workflow in the default package seems very reasonable to me. I don't understand why it was disabled in the first place.
027ff16 to
36fa1f1
Compare
|
Mass rebuild -> target staging branch. |
Git should come with a reasonable set of baseline features. Arguable git-send-email is one of them. Development flows, such as those of Linux, depend on the tool being available. The difference in closure size between this and the previous version is is negligible. There are no additional build-time dependencies pulled in and the runtime closure difference is about 1%.
36fa1f1 to
37a44b4
Compare
That is surprising in multiple ways. I did run the old maintainers script that supposedly checks rebuild amounts. It didn't look too bad. Apparently |
|
Actually, this change is a no-op for |
#206195 might be related |
|
LGTM, cross-compiled git won't enable send-email but that's fine. Otherwise it wasn't building properly anyway :) |
Description of changes
Git should come with a reasonable set of baseline features. Arguable git-send-email is one of them. Development flows, such as those of Linux, depend on the tool being available.
The difference in closure size between this and the previous version is is negligible. There are no additional build-time dependencies pulled in and the runtime closure difference is about 1%.
Things done