clisp: pin to readline6 to fix the build#206745
Merged
trofi merged 1 commit intoNixOS:masterfrom Dec 19, 2022
Merged
Conversation
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
tjni
approved these changes
Dec 18, 2022
Contributor
tjni
left a comment
tjni
left a comment
There was a problem hiding this comment.
Thank you for tracking this down and fixing it.
Nit on the commit messages:
fix bthe build => fix the build
the varilables => the variables
On readline8 clisp fails to find the variables and fails to build: https://hydra.nixos.org/log/rbykd92038rp80a71diyxqmbiz4m8f60-clisp-2.49.drv *** - FFI::FIND-FOREIGN-VARIABLE: foreign variable #<FOREIGN-VARIABLE "rl_readline_state" #x00007FFFF7FBC640> does not have the required size or alignment The pin back fixes build for me. Noticed by Athas on libera/#nixos.
trofi
force-pushed
the
clisp-fix-readline
branch
from
d226da6 to
83f6bed
Compare
trofi
changed the title
Contributor
Author
Good catch! Attempted to fix both in commit message and PR description. |
rodrgz
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On readline8 clisp fails to find the variables and fails to build: https://hydra.nixos.org/log/rbykd92038rp80a71diyxqmbiz4m8f60-clisp-2.49.drv
The pin back fixes build for me.
Noticed by Athas on libera/#nixos.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes