Skip to content

helmfile: 0.145.2 -> 0.150.0#206734

Closed
brenix wants to merge 4 commits intoNixOS:masterfrom
brenix:helmfile-0.149.0
Closed

helmfile: 0.145.2 -> 0.150.0#206734
brenix wants to merge 4 commits intoNixOS:masterfrom
brenix:helmfile-0.149.0

Conversation

@brenix
Copy link
Contributor

@brenix brenix commented Dec 18, 2022 •
edited
Loading

Description of changes

https://github.com/helmfile/helmfile/releases/tag/v0.150.0

Also fixes completions as that did not seem to be working.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kliu128 and yurrriq December 18, 2022 18:40
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 18, 2022
yurrriq
yurrriq requested changes Jan 11, 2023
View reviewed changes
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've made a suggestion/request for postInstall.

@ofborg ofborg bot requested a review from yurrriq January 11, 2023 19:12
@yurrriq
Copy link
Member

yurrriq commented Jan 13, 2023

Result of nixpkgs-review pr 206734 run on x86_64-linux 1

1 package built:
  • helmfile

@brenix brenix changed the title helmfile: 0.145.2 -> 0.149.0 helmfile: 0.145.2 -> 0.150.0 Jan 17, 2023
@ofborg ofborg bot requested a review from yurrriq January 17, 2023 16:25
@wegank wegank mentioned this pull request Feb 10, 2023
Merged
13 tasks
@yurrriq
Copy link
Member

yurrriq commented Feb 14, 2023

Sorry for the delay. I've been quit preoccupied and had forgotten the preferred strategy re: squashing. Looks like #215452 was merged instead. Thanks for your time and effort, @brenix!

@yurrriq yurrriq closed this Feb 14, 2023
@brenix
Copy link
Contributor Author

brenix commented Feb 15, 2023

No worries, thanks!

@brenix brenix deleted the helmfile-0.149.0 branch May 30, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kliu128 kliu128 Awaiting requested review from kliu128

@yurrriq yurrriq Awaiting requested review from yurrriq

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brenix @yurrriq