Skip to content

Conversation

@dyercode
Copy link

…g/0.52.2

llvm patch removed upstream.

Description of changes

Bump ponyc version.
google benchmarks updated to make compile. Step to apply an LLVM patch removed as in upstream ponylang/ponyc#4192

https://github.com/ponylang/ponyc/releases/tag/0.52.2

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • [] Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kamilchm and redvers December 10, 2022 19:11
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 10, 2022
@risicle risicle changed the title ponyc: 0.50.0 -> 0.52.2 https://github.com/ponylang/ponyc/releases/ta… ponyc: 0.50.0 -> 0.52.2 Dec 10, 2022
@risicle
Copy link
Contributor

risicle commented Dec 10, 2022

Please remove the url from the commit message.

Or at least put it on another line.

@dyercode
Copy link
Author

I can do that, But I followed the example at https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md. firefox: 54.0.1 -> 55.0 https://www.mozilla.org/en-US/firefox/55.0/releasenotes/

llvm patch removed upstream.
@risicle
Copy link
Contributor

risicle commented Dec 11, 2022

Um.. that's interesting, I'm not sure I (or 99% of contributors) got the memo over that change...

@dyercode
Copy link
Author

Is what these darwin builds are doing normal?

@risicle
Copy link
Contributor

risicle commented Dec 11, 2022

Not particularly unusual if e.g. a llvm-rebuilding PR has been merged recently.

@risicle
Copy link
Contributor

risicle commented Dec 11, 2022

Oh hold on looks like ponyc has an embedded copy of llvm itself. Yes, I wouldn't expect ofborg to ever get enough time to build this.

@redvers
Copy link
Member

redvers commented Feb 5, 2023

Firstly @dyercode, please accept my apology for not seeing the request for review for this until now. I found it as I was working on a PR to bring to 0.53.0 since 0.50.0 now won't compile due to dn.h (DECNet).

Another issue has emerged via #213185 where the build additionally fails as it is unable to locate libstdc++.a using clang++.

In other words, we can't do any updates to ponyc until that PR hits master.

When that happens, I'm happy to send you all the changes I made to 0.53.0 so you can raise a new PR, or… I can just push it when the time comes.

Regardless, please consider adding yourself to the maintainers :-) <3

@wegank
Copy link
Member

wegank commented Feb 5, 2023

Firstly @dyercode, please accept my apology for not seeing the request for review for this until now. I found it as I was working on a PR to bring to 0.53.0 since 0.50.0 now won't compile due to dn.h (DECNet).

Another issue has emerged via #213185 where the build additionally fails as it is unable to locate libstdc++.a using clang++.

In other words, we can't do any updates to ponyc until that PR hits master.

When that happens, I'm happy to send you all the changes I made to 0.53.0 so you can raise a new PR, or… I can just push it when the time comes.

Regardless, please consider adding yourself to the maintainers :-) <3

I guess we can target staging-next?

@dyercode
Copy link
Author

dyercode commented Feb 5, 2023

Firstly @dyercode, please accept my apology for not seeing the request for review for this until now. I found it as I was working on a PR to bring to 0.53.0 since 0.50.0 now won't compile due to dn.h (DECNet).

Another issue has emerged via #213185 where the build additionally fails as it is unable to locate libstdc++.a using clang++.

In other words, we can't do any updates to ponyc until that PR hits master.

When that happens, I'm happy to send you all the changes I made to 0.53.0 so you can raise a new PR, or… I can just push it when the time comes.

Regardless, please consider adding yourself to the maintainers :-) <3

No worries. Was just something I was fiddling with for advent of code and seemed easy enough to contribute to save myself some recovers. LMK if you need me to do anything to this.

@redvers
Copy link
Member

redvers commented Apr 25, 2023

Obsoleted by #220073

You know… if you want to add yourself to the maintainers we'd be happy to have you ♥

@redvers redvers closed this Apr 25, 2023
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants