Skip to content

lunarml: init at unstable-2023-06-25#205407

Merged
ncfavier merged 1 commit intoNixOS:masterfrom
toastal:lunarml
Jul 16, 2023
Merged

lunarml: init at unstable-2023-06-25#205407
ncfavier merged 1 commit intoNixOS:masterfrom
toastal:lunarml

Conversation

@toastal
Copy link
Contributor

@toastal toastal commented Dec 10, 2022

Description of changes

https://github.com/minoki/LunarML

doCheck passes their built-in tests. I had a chat with the upstream project and got it slightly restructured in a way that cut the Nix code by 2/3.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 10, 2022
@toastal toastal force-pushed the lunarml branch 3 times, most recently from f7db872 to c5b07d3 Compare December 13, 2022 05:59
@ofborg ofborg bot requested a review from gebner December 13, 2022 06:10
@ofborg ofborg bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 13, 2022
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 13, 2022
@toastal toastal changed the title lunarml: init @ unstable-2022-12-03 lunarml: init @ unstable-2022-12-12 Dec 14, 2022
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 6c338a4 to 3b6b111 Compare December 14, 2022 14:42
@toastal toastal changed the title lunarml: init @ unstable-2022-12-12 lunarml: init at unstable-2022-12-12 Dec 14, 2022
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 97473c1 to b7f4019 Compare December 19, 2022 05:04
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 5ec8a3a to 0df3ed7 Compare December 20, 2022 16:42
@toastal toastal force-pushed the lunarml branch 4 times, most recently from 66b30df to 63d020d Compare December 25, 2022 18:09
@toastal
Copy link
Contributor Author

toastal commented Feb 14, 2023

@ncfavier the $out being broken up is still confusing to me on where the line really is. I believe I saw the tests actually running the scripts at the end of the test phase though.

@toastal toastal changed the title lunarml: init at unstable-2022-12-25 lunarml: init at unstable-2022-02-12 Feb 14, 2023
@toastal toastal force-pushed the lunarml branch 4 times, most recently from 4927e9b to 157ea96 Compare March 14, 2023 06:17
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 47e633c to 3d7147a Compare March 21, 2023 09:51
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 8e6699c to 4b7bed9 Compare March 29, 2023 12:38
@toastal toastal force-pushed the lunarml branch 2 times, most recently from e77f6b7 to a219939 Compare May 13, 2023 13:59
@toastal toastal force-pushed the lunarml branch 2 times, most recently from 6879df0 to adde0fb Compare June 8, 2023 11:30
@toastal toastal force-pushed the lunarml branch 4 times, most recently from c4e9569 to c55cc15 Compare June 28, 2023 04:55
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jun 28, 2023
@toastal toastal force-pushed the lunarml branch 2 times, most recently from b6e88b8 to 5fb08ca Compare July 7, 2023 04:54
@toastal toastal changed the title lunarml: init at unstable-2022-02-12 lunarml: init at unstable-2023-06-25 Jul 7, 2023
@toastal toastal requested a review from ncfavier July 7, 2023 05:13
@toastal
Copy link
Contributor Author

toastal commented Jul 7, 2023

@ncfavier I tried to use multiple outputs but the binary is very finicky about where lib is. It must be located absolutely from ../lib which if lib is at $lib, then it will be at a different absolute path in the Nix store. Not even a symlink is followed.

@ncfavier
Copy link
Member

ncfavier commented Jul 7, 2023

I didn't ask to move lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants