Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maturin: 0.13.0 -> 0.14.5 #205211

Merged
merged 1 commit into from
Dec 18, 2022
Merged

maturin: 0.13.0 -> 0.14.5 #205211

merged 1 commit into from
Dec 18, 2022

Conversation

luizirber
Copy link
Contributor

@luizirber luizirber commented Dec 8, 2022

Description of changes

Upstream changelog: https://github.com/PyO3/maturin/blob/main/Changelog.md#0140---2022-11-19

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    • seeing ~15 failures during testing (not compiling), most from tensorflow/JAX related packages.
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@luizirber
Copy link
Contributor Author

This is technically a major version bump, should I document it in the 23.05 release notes?

@risicle
Copy link
Contributor

risicle commented Dec 10, 2022

Found no new failures building all affected python310Packages.* on aarch64-linux.

This will need to be re-targeted at staging though using the method described in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

@mweinelt mweinelt marked this pull request as draft December 10, 2022 00:37
@luizirber luizirber changed the base branch from master to staging December 10, 2022 03:24
@luizirber
Copy link
Contributor Author

This will need to be re-targeted at staging though using the method described in https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#rebasing-between-branches-ie-from-master-to-staging

Just did that! (sorry if I'm making a mess in this PR, my first time contributing to nixpkgs...)

@risicle
Copy link
Contributor

risicle commented Dec 10, 2022

Found no new failures building all affected python310Packages.* on macos 10.15.

@mweinelt mweinelt marked this pull request as ready for review December 11, 2022 00:49
@luizirber
Copy link
Contributor Author

Sorry for spamming here, but is the etiquette to keep the branch updated with staging while it is not approved/merged, or that would just cause CI churn?

@risicle
Copy link
Contributor

risicle commented Dec 18, 2022

Let's circumvent that issue entirely.

@risicle risicle merged commit 797037b into NixOS:staging Dec 18, 2022
@risicle
Copy link
Contributor

risicle commented Dec 18, 2022

(answer - usually only if there's a merge conflict)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants