Skip to content

boost: add configurable enableIcu flag#205166

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
oxalica:fix/boost-icu-flag
Dec 9, 2022
Merged

boost: add configurable enableIcu flag#205166
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
oxalica:fix/boost-icu-flag

Conversation

@oxalica
Copy link
Contributor

@oxalica oxalica commented Dec 8, 2022

Description of changes

This makes it easier to disable ICU support with override, where the closure size matters.

See NixOS/nix#7336 (comment)

Default:

/nix/store/7kg4j7isk2rcplc6glk8kfbvwsf14h08-boost-1.79.0          90.4M

With enableIcu disabled:

/nix/store/99hmy5xbv36zyvkj27gbl0qi6l9kgh2b-boost-1.79.0          51.8M
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

This makes it easier to disable ICU support with `override`, where
the closure size matters.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 8, 2022
@SuperSandro2000 SuperSandro2000 merged commit f907897 into NixOS:master Dec 9, 2022
@SuperSandro2000
Copy link
Member

Always nice to expose such options

@oxalica oxalica deleted the fix/boost-icu-flag branch December 9, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants