Skip to content

crosvm: warn that NIX_CFLAGS_COMPILE will break the build #204694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

crosvm: warn that NIX_CFLAGS_COMPILE will break the build #204694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions pkgs/applications/virtualization/crosvm/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
, libcap, libdrm, libepoxy, minijail, virglrenderer, wayland, wayland-protocols
}:

rustPlatform.buildRustPackage rec {
(rustPlatform.buildRustPackage rec {
pname = "crosvm";
version = "107.1";

Expand Down Expand Up @@ -60,4 +60,9 @@ rustPlatform.buildRustPackage rec {
license = licenses.bsd3;
platforms = [ "aarch64-linux" "x86_64-linux" ];
};
}
})
.overrideAttrs (a:
lib.warnIf (a.NIX_CFLAGS_COMPILE or "" != "")
''you have set `NIX_CFLAGS_COMPILE` to ${a.NIX_CFLAGS_COMPILE}
this may cause crosvm's build scripts to produce an empty
constants.json and then fail to complete the build'' {})