Skip to content

treewide: drop wxGTK30-gtk2#204214

Merged
Artturin merged 1 commit intoNixOS:masterfrom
wegank:wxgtk30-gtk2-drop
Dec 6, 2022
Merged

treewide: drop wxGTK30-gtk2#204214
Artturin merged 1 commit intoNixOS:masterfrom
wegank:wxgtk30-gtk2-drop

Conversation

@wegank
Copy link
Member

@wegank wegank commented Dec 3, 2022 •
edited
Loading

Description of changes

This PR has zero rebuilds, since we don't have any non-broken packages depending on wxGTK30-gtk2.

Supersedes #73145.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 3, 2022
@wegank wegank force-pushed the wxgtk30-gtk2-drop branch 2 times, most recently from 6b9bc82 to 36508ed Compare December 3, 2022 02:00
@wegank wegank force-pushed the wxgtk30-gtk2-drop branch from 36508ed to 07cd65b Compare December 3, 2022 02:28
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 3, 2022
@Artturin
Copy link
Member

Artturin commented Dec 3, 2022

Been 2 years since the last try and now there's 0 rebuilds so lgtm

@mweinelt mweinelt added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 4, 2022
@nixos-discourse
Copy link

nixos-discourse commented Dec 6, 2022

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/715

@Artturin Artturin merged commit 850fb23 into NixOS:master Dec 6, 2022
@wegank wegank deleted the wxgtk30-gtk2-drop branch December 7, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Artturin Artturin Artturin approved these changes

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

@dasJ dasJ Awaiting requested review from dasJ

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wegank @Artturin @nixos-discourse @mweinelt