Skip to content

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Dec 1, 2022

This also reenables tests on Darwin. If the tests end up being flaky again, let's disable them individually (if we can't fix them).

I've disabled three tests that fail on my aarch64-darwin machine which didn't fail on an x86_64-darwin VM. Experimenting locally suggests that it's more related to assumptions made in the tests on how SSL handshake should be done than any actual real issue. I've reached out to the maintainers on IRC separately to try to resolve this properly upstream.

This is a follow up to #187636.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni requested review from FRidh and jonringer as code owners December 1, 2022 21:41
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Dec 1, 2022
@tjni tjni changed the title python310Packages.pyopenssl: unbreak on darwin-aarch64 python310Packages.pyopenssl: unbreak on aarch64-darwin Dec 1, 2022
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 1, 2022
@ofborg ofborg bot requested a review from SuperSandro2000 December 1, 2022 22:03
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 1, 2022
This also reenables tests on Darwin. If the tests end up being flaky
again, let's disable them individually (if we can't fix them).
@ofborg ofborg bot requested a review from SuperSandro2000 December 2, 2022 17:56
@ofborg ofborg bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 2, 2022
@SuperSandro2000 SuperSandro2000 merged commit b06dbde into NixOS:staging Dec 3, 2022
@tjni tjni deleted the pyopenssl branch December 3, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 2501-5000 This PR causes many rebuilds on Darwin and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants